Graphviz Issue Tracker
Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002206graphvizBuild/Installpublic2012-02-28 15:262012-02-28 17:27
Reporterslitvinov 
Assigned Toellson 
PrioritylowSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformallOSallOS Versionall
Summary0002206: typo in configure.ac
DescriptionThere is a typo in configure.ac. It creates a mismatch between "./configure -h" message and ./configure option name.

See Additional Information and a patch I am attaching.
Additional Information--- a/configure.ac Tue Feb 28 12:47:36 2012 -0500
+++ b/configure.ac Tue Feb 28 21:22:02 2012 +0100
@@ -269,17 +269,17 @@ AC_CHECK_PROGS(SORT,gsort sort,false)
 AC_CHECK_PROG(EGREP,egrep,egrep,false)
 AC_CHECK_PROG(GROFF,groff,groff,false)
 AC_CHECK_PROG(PS2PDF,ps2pdf,ps2pdf,false)
 AC_CHECK_PROG(PS2PDF,pstopdf,pstopdf,false)
 
 PKG_PROG_PKG_CONFIG
 
 AC_ARG_WITH(tclsh,
- [AS_HELP_STRING([--with-tcl=PROG],[use a specific tclsh])],
+ [AS_HELP_STRING([--with-tclsh=PROG],[use a specific tclsh])],
   TCLSH=$withval,)
 
 if test "x$TCLSH" = "x"; then
   AC_PATH_PROGS(TCLSH,[tclsh8.6 tclsh8.5 tclsh8.4 tclsh8.3 tclsh])
 # if test "x$TCLSH" = "x"; then
 # AC_MSG_ERROR([Unable to find a tclsh. Tclsh is a required program for building graphviz, independent of wether tcl-based graphviz products are built])
 # use_tcl="No (tclsh unavailable)"
 # fi
Tagsautoconfigure, build
AUXILLARY-FILES
DATE-FIXED
FIX-COMMENTtypo correction "--with-tclsh" applied
FORMER-ID
INPUT-FILE
OUTPUT-FILE
STATUS-COMMENT
VERSION
Attached Filespatch file icon conf.patch [^] (893 bytes) 2012-02-28 15:26 [Show Content]

- Relationships

-  Notes
User avatar (0000198)
ellson (administrator)
2012-02-28 16:11

I don't think you tested your patch? If WITH_TCL is changed then it also needs
to change in various */*/Makefile.am

Why is it important to you? Arguably I'm only using tclsh to find tclConfig.sh, libtcl.so and tcl.h, and so WITH_TCL is not too inappropriate?
User avatar (0000199)
slitvinov (reporter)
2012-02-28 16:56

I think the patch changes only a help string. Now one sees
 ./configure -h | grep with-tcl
 --with-tcl=PROG use a specific tclsh
And I think it is confusing because setting --with-tcl=<..> has no effect.

- Issue History
Date Modified Username Field Change
2012-02-28 15:26 slitvinov New Issue
2012-02-28 15:26 slitvinov File Added: conf.patch
2012-02-28 15:27 slitvinov Tag Attached: autoconfigure
2012-02-28 15:27 slitvinov Tag Attached: build
2012-02-28 16:11 ellson Note Added: 0000198
2012-02-28 16:56 slitvinov Note Added: 0000199
2012-02-28 17:27 ellson FIX-COMMENT => typo correction "--with-tclsh" applied
2012-02-28 17:27 ellson Status new => resolved
2012-02-28 17:27 ellson Resolution open => fixed
2012-02-28 17:27 ellson Assigned To => ellson


MantisBT 1.2.5[^]
Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker