Number: 1249
Title: Parallel build issues in tclpkg/gv/Makefile.am
Submitter: Martin von Gagern
Date: Mon Dec 17 16:33:32 2007
Subsys: Build/Installation
Version: 2.16.1
System: *-*-
Severity: cosmetic
Problem:
Building graphviz in parallel (using -j# option to make) will likely result in an error message for gv_python.cpp as the file may get compiled before it is completely written. Reported also here: http://bugs.gentoo.org/show_bug.cgi?id=202618

There were similar issues in the past: http://www.graphviz.org/bugs/b1111.html The patch attached there had been applied in revision 1.69 of tclpkg/gv/Makefile.am, but the python hunk had been left out for some reason.
Comments:
[ellson] Did you actually encounter this problem, or are you catching this with some kind of lint tool?

I ask because I use "make -j" all the time on a dual processor machine, and have not encountered any problems here.
Fix: 


diff -ur graphviz-2.16.1.orig/tclpkg/gv/Makefile.am graphviz-2.16.1/tclpkg/gv/Makefile.am
--- graphviz-2.16.1.orig/tclpkg/gv/Makefile.am	2007-12-17 22:10:02.000000000 +0100
+++ graphviz-2.16.1/tclpkg/gv/Makefile.am	2007-12-17 22:12:40.000000000 +0100
@@ -124,7 +124,8 @@
 libgv_python_la_SOURCES = $(BASESOURCES) gv_dummy_init.cpp
 libgv_python_la_LIBADD = $(BASELIBS) @PYTHON_LIBS@
 libgv_python_la_LDFLAGS = -module -avoid-version
-gv_python.cpp $(PYTHON_data): gv.i
+$(PYTHON_data): gv_python.cpp
+gv_python.cpp: gv.i
 	$(SWIG) -c++ -python -o gv_python.cpp $(srcdir)/gv.i


 pkgpython23dir = $(pkglibdir)/python23

Owner: ellson
Status: Fixed (17 Dec 2007)